mirror of
https://github.com/anomalyco/hex.git
synced 2026-11-22 21:23:02 +01:00
Ryan's decision: where the keyboard can dictate by itself (iOS 26, KeyboardLocalDictation), Keep mic warm defaults to Off and its row is hidden; everywhere else it stays as it was. There a warm session did nothing useful and got in the way: the keyboard records through it instead of dictating itself, which also bypasses the speech model now running in the keyboard. What changed - KeyboardSelfDictation (new, HEXShared): one answer to "can this phone's keyboard dictate by itself?": iOS 26 or later, no keyboardNeedsHex (case 3), Experiments > Multilingual model not taking the language while only Hex can load it (case 4, unless Speech model in keyboard is on), and no record of Dictate opening Hex in the last 7 days. The keyboard writes that record (reason + time: memory, speechModel or multilingual) when its cold-start URL opens Hex because it can't dictate here (case 2 left no record before), and clears it the next time it dictates in the keyboard. - KeyboardBridge.warmDuration: unset now reads Off where the keyboard dictates by itself and 15m elsewhere, worked out on each read, never stored (replaces the fixed 15m fallback). Nothing writes the default at first launch, but tapping the already-selected 15m (to warm the mic) stored it, so once on iOS 26 a stored 15m is taken for not chosen where the keyboard dictates by itself; Off, 5m and 1h stay as chosen. This runs in DictationController.init, where no warm session can be running yet. - DictationController: the duration in effect is read again as Hex becomes active and as the keyboard opens it (refreshWarmDuration, in the new DictationController+WarmDefault.swift); when it turns Off an idle warm session ends. With Off where the keyboard dictates by itself, a keyboard launch that missed its recording (Timed out, or /start) no longer starts a 15-minute warm session; it warms nothing. A Dictate that opens Hex in time still records one shot, as before. - Settings > Dictation: Keep mic warm shows unless it would say Off where the keyboard dictates by itself; any duration in effect shows it, and once picked it stays on the page (so picking Off doesn't pull it from under the finger). No new strings. - README's warm-session paragraph says so. Verified - xcodebuild test on an iOS 27.2 simulator (Mac Studio): 859 tests, 3 skipped (clip and replay fixtures), 0 failures. New cases in existing files: KeyboardBridgeTests (default per OS version 18/25/26/27, the memory record and its 7-day window, keyboardNeedsHex, multilingual with and without Speech model in keyboard, a choice kept; the one-time review of a stored 15m) and DictationControllerTests (Off hides the row, a timed-out handoff warms nothing, a memory record brings 15m and the row back, clearing it ends the idle session). testTenSecondHandoffWindow now sets 15m explicitly, since it pins the warm path. iOS 18-25 covered only by passing the version in; not run on a real iOS 18. - In the real app on the simulator: a fresh install shows no Keep mic warm row and no warm timer; an install of origin/dev with 15m stored, updated to this build, reads Off with the row hidden and the key removed; one with 1h kept 1h and the row; with the keyboard's memory record set, the row came back with 15m. The simulator has no Apple Speech model, so Hex marks keyboardNeedsHex there itself; the self-dictating states were checked with that mark cleared. - python3 scripts/code-shape.py passes; git diff --check clean.
22 lines
900 B
Swift
22 lines
900 B
Swift
import Foundation
|
||
|
||
extension DictationController {
|
||
/// Keep mic warm's default follows the keyboard (`KeyboardBridge.warmDuration`): read again
|
||
/// as Hex comes back and as the keyboard opens it. Where it becomes Off, an idle warm
|
||
/// session ends.
|
||
func refreshWarmDuration() {
|
||
guard !OnboardingFixture.isSnapshot else { return }
|
||
let current = keyboardBridge.warmDuration
|
||
guard current != warmDuration else { return }
|
||
warmDuration = current
|
||
if current == .off, keyboardSessionEnabled, phase == .ready {
|
||
endWarmSession()
|
||
}
|
||
}
|
||
|
||
/// Settings › Dictation › Keep mic warm, unless it would say Off where the keyboard
|
||
/// dictates by itself: a duration in effect always shows, so it can be turned off.
|
||
var showsKeepMicWarm: Bool {
|
||
warmDuration != .off || !keyboardBridge.keyboardDictatesItself()
|
||
}
|
||
}
|