hex/ios/HEXShared/FullKeyboard/FullKeyboardEngine+Field.swift
Ryan Vogel 92344726c1
iOS keyboard: a swipe right after its word was deleted types its next reading (#2422)
What changed: a swiped word deleted right after the swipe (the whole-word delete, or, with
Settings > Experiments > Delete swiped words letter by letter, deletes taking out every character
the swipe typed) counts as taken back at that place. The next swipe there types the first of its
readings not taken back; the words taken back follow the others, so the strip may still offer
them, never first. Every word taken back at one place in a row counts ("two", then "yep"). One
place: the same text before the cursor, trailing spaces aside, in the same field, with only those
swipes and deletes in between. Any other edit (a letter, a space, punctuation, a pick from the
strip), a swipe elsewhere, another field or text moved around the keys forgets them. A swipe whose
readings were all taken back still types the decoder's first. The swipe preview shows the reading
that will go in.

Where: FullKeyboardEngine.SwipeRetries (FullKeyboardEngine+SwipeTyping.swift) reorders the
readings where endSwipe commits them; SwipeDecoder.swift (being ported to Rust in #2309, with a
parity fixture), SwipeTyping.swift and TypingDecoder.swift are untouched, so the decoder's readings
for a path don't change. FullKeyboardEngine.swift gets 6 lines of hooks (1,490 lines), didEdit one.

Why: Record typing logs: "two" swiped three times running for "yep", each deleted, while the strip
offered "yep"; swipes were the worst class left (7 of 19 wrong, against 5% of tapped words).

Changed test: testSwipedWordsTakeACapitalOnlyWhereApplesKeyboardGivesOne swiped "bell", deleted
it and swiped "bell" again, expecting "bell": that re-swipe now gives the next reading, by design.
Its point is the capital after a delete, so it now deletes a swiped "rang" before swiping "will";
its expected text is unchanged.

Verified:
- FullKeyboardEngineTests: testASwipeRightAfterItsWordWasDeletedTypesTheNextReading (next
  reading, two taken back, a letter in between, the only reading, letter by letter) and
  testTheSamePathSwipedAgainAfterADeleteTypesTheStripsReading (real decoder: "hello", delete,
  "help"); both fail on dev.
- A tester's 19 swipes replayed, each re-swipe after the swipes deleted before it at that place:
  "yep" right on the 2nd swipe instead of the 4th; "are" (3 swipes) and "live" (2) unchanged; the
  10 words swiped once unchanged (9 right).
- iOS typing gate (typing-gate.py, en/es/de, deterministic hashing): every output identical
  (en 734 errors, 36 changed; es 1,132, 22; de 872, 16; critical 2/2 each).
- xcodebuild test on the Studio (own simulator): 909 tests, 0 failures, 4 opt-in skips. code-shape.py: no hard problems.
2026-11-22 14:40:55 -05:00

16 lines
508 B
Swift

import UIKit
/// The one edit notification: kept beside the engine like the trackpad's own code so
/// `FullKeyboardEngine.swift` stays readable.
@MainActor
extension FullKeyboardEngine {
func didEdit() {
suggestionSpaceBefore = nil
swipeRetries.edited()
// A key's own edit means a pending Dictate no longer has the field it picked.
trackpadSelectionState.pendingDictation = nil
refreshAutoCapitalization()
refreshSuggestions()
onEdit?()
}
}