hex/ios/HEXShared/TypingLog
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Ryan Vogel 8b879d8ac4
iOS keyboard: remove the "Logging" mark; Record typing logs is only the switch (#2382)
Ryan: "When you have typing logging on, it doesn't show anything for that. It's
only a toggle in settings, because the logging UI just looks horrible. So we need
to just remove it completely."

Removed behaviour: with Settings › Privacy › Advanced › Record typing logs on, the
keyboard no longer shows a "● Logging" mark anywhere. Previously the mark sat in
the full keyboard's suggestion strip corner (TypingLogMarkView, which also pushed
the Full Access hint aside and made the outer suggestion slot centre its word in
the rest), at the end of the recording bar's Dot Scope well (which shortened the
scope), and beside the Hex mark in the dictation bar's top row (TypingLogMark).

Removed with it: KeyboardStripView/HexKeyRecordingPanel.showsLoggingMark and their
layout branches, SlotButton.leadingRoom/trailingRoom (the mark was their only
user), KeyboardViewModel.isLoggingTyping, KeyboardViewController.syncLoggingMark()
and its three calls (it only fed the mark; starting and ending log sessions and
attachTypingLog are unchanged), the --typing-log-mark launch argument in the
snapshot stage and preview host, the mark's assertions in
testTheRecordingBarMirrorsWithTheHexKey (the test keeps checking the bar's layout
without it), and the mark's mentions in ios/README.md, TypingLogSession.swift and
KeyboardStripView.swift. No localized string was the mark's.

Unchanged: the switch and its consent dialog, the Typing logs screen, the
one-time migration, and everything recording does (events, skipped fields, caps,
14 days).

Verified on the Mac Studio, iOS 27.2 iPhone 17 Pro simulator:
- xcodebuild test: 853 tests, 3 skipped, 0 failures.
- python3 scripts/code-shape.py passes.
- Release build of the real keyboard extension in a hosted field, logging off vs
  on (--experiment-typing-logs, App Group flag read back as 1 and 0): the
  suggestions strip, the Full Access hint, the full keyboard's recording bar and
  the dictation bar keyboard look the same (strip crops pixel-identical for
  suggestions and dictation bar; the hint differs by one antialiased pixel, the
  recording bar only in its animated Dot Scope dots).
- With it on, typing wrote TypingLogs/<day>.ndjson in the App Group (session_start,
  touch, edit, candidates, context, layout lines).
2026-11-22 10:50:35 -05:00
..
DictationStages.swift ios: record raw typing logs from Hex's keyboard (experiment) (#2024) 2026-11-20 02:13:16 +00:00
TypingLogEvent.swift ios: record raw typing logs from Hex's keyboard (experiment) (#2024) 2026-11-20 02:13:16 +00:00
TypingLogger.swift iOS keyboard: the full keyboard on iPad, sized like Apple's iPad keyboards (#2313) 2026-11-21 22:31:56 -05:00
TypingLogSession.swift iOS keyboard: remove the "Logging" mark; Record typing logs is only the switch (#2382) 2026-11-22 10:50:35 -05:00
TypingLogStore.swift ios: record raw typing logs from Hex's keyboard (experiment) (#2024) 2026-11-20 02:13:16 +00:00